Skip to content

Commit b57f5a7

Browse files
authored
Merge pull request #754 from firebase/feature/admob_2021_leaderboard
Rename Admob LeaderBoard AdSize to Leaderboard to match AdMob naming conventions.
2 parents 27203e2 + b9ebfb4 commit b57f5a7

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

admob/integration_test/src/integration_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,7 @@ TEST_F(FirebaseAdMobTest, TestAdSize) {
475475
EXPECT_EQ(fullbanner.type(), AdSize::kTypeStandard);
476476
EXPECT_EQ(fullbanner.orientation(), AdSize::kOrientationCurrent);
477477

478-
const AdSize leaderboard = AdSize::kLeaderBoard;
478+
const AdSize leaderboard = AdSize::kLeaderboard;
479479
EXPECT_EQ(leaderboard.width(), 728);
480480
EXPECT_EQ(leaderboard.height(), 90);
481481
EXPECT_EQ(leaderboard.type(), AdSize::kTypeStandard);

admob/src/common/admob_common.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ AdResult AdMobInternal::CreateAdResult(
8787
const AdSize AdSize::kBanner(/*width=*/320, /*height=*/50);
8888
const AdSize AdSize::kFullBanner(468, 60);
8989
const AdSize AdSize::kLargeBanner(320, 100);
90-
const AdSize AdSize::kLeaderBoard(728, 90);
90+
const AdSize AdSize::kLeaderboard(728, 90);
9191
const AdSize AdSize::kMediumRectangle(300, 250);
9292

9393
AdSize::AdSize(uint32_t width, uint32_t height)

admob/src/include/firebase/admob/types.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ class AdSize {
351351

352352
/// Interactive Advertising Bureau (IAB) leaderboard ad size
353353
/// (728x90 density-independent pixels).
354-
static const AdSize kLeaderBoard;
354+
static const AdSize kLeaderboard;
355355

356356
/// Interactive Advertising Bureau (IAB) medium rectangle ad size
357357
/// (300x250 density-independent pixels).

0 commit comments

Comments
 (0)