Skip to content

Remove unnecessary swig logic from Analytics #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Remove some extra swig logic that is unnecessarily in the C++ header file. The logic to add the unsafe tag was already in the Unity SDK's swig file, and it will be going away soon anyway.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Sep 10, 2024
@a-maurice a-maurice enabled auto-merge (squash) September 10, 2024 23:48
@a-maurice a-maurice merged commit 8716ff4 into main Sep 11, 2024
30 checks passed
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Sep 11, 2024
Copy link

⏳  Integration test in progress...

Requested by @a-maurice on commit 8716ff4
Last updated: Tue Sep 10 17:47 PDT 2024
View integration test log & download artifacts

@a-maurice a-maurice deleted the am-analytics_rewrite branch October 1, 2024 22:08
@firebase firebase locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: in-progress This PR's integration tests are in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants