Skip to content

Add retry to RTDB .info/connected test on iOS. #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2021

Conversation

jonsimantov
Copy link
Contributor

The iOS SDK's .info/connected implementation sometimes fails, so add some flaky retry logic (but only when running on iOS).

@google-cla google-cla bot added the cla: yes label Aug 10, 2021
@jonsimantov jonsimantov added skip-release-notes Skip release notes check and removed cla: yes labels Aug 10, 2021
@google-cla google-cla bot added the cla: yes label Aug 10, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Aug 10, 2021
@jonsimantov jonsimantov requested a review from a-maurice August 10, 2021 20:09
@jonsimantov jonsimantov changed the title Deflake RTDB .info/connected test on iOS. Add retry to RTDB .info/connected test on iOS. Aug 10, 2021
@jonsimantov jonsimantov added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels Aug 10, 2021
@jonsimantov jonsimantov added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels Aug 10, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Aug 11, 2021
@github-actions
Copy link

github-actions bot commented Aug 11, 2021

✅  Integration test succeeded!

Requested by @jonsimantov on commit ffe2fb7
Last updated: Wed Aug 11 09:23 PDT 2021
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Aug 11, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 11, 2021
@jonsimantov jonsimantov merged commit ffe2fb7 into main Aug 11, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Aug 11, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 11, 2021
@jonsimantov jonsimantov deleted the bugfix/deflake-dbinfoconnected branch August 13, 2021 18:42
@firebase firebase locked and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants