Add presubmit trigger with ccache in linux firestore #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunmou99
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
❌ Integration test FAILEDRequested by @sunmou99 on commit 708ec9c
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
sunmou99
changed the title
sunmou99
changed the title
sunmou99
changed the title
firebase-workflow-trigger
bot
removed
the
tests: in-progress
sunmou99
added
the
tests-requested: full
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
sunmou99
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
jonsimantov
approved these changes
Sep 16, 2021
| echo "::set-output name=github_ref::refs/pull/${{github.event.inputs.test_pull_request}}/merge" | ||
| echo "::set-output name=pr_number::${{ github.event.inputs.test_pull_request }}" | ||
| fi | ||
| elif [[ "${{ github.event.inputs.test_pull_request }}" == "sdk" ]]; then |
There was a problem hiding this comment.
Remind me, did this value already exist? Why does it need to be set if we have the test_packaged_sdk input?
There was a problem hiding this comment.
This value already exist. https://github.com/firebase/firebase-cpp-sdk/blob/main/.github/workflows/cpp-packaging.yml#L725
Because it means it's from scheduled packaging workflow, thus it can generate nightly report. test_packaged_sdk only indicates that it's from packaging workflow.
There was a problem hiding this comment.
Got it. Maybe we should change it to "nightly-packaging" or something a little more descriptive in the future. But it's fine for now.
github-actions
bot
added
the
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined "check_trigger" job and "prepare_matrix" job into "check_and_prepare" job.
Added "trigger" env variable. Apply "expanded_matrix, minimal_matrix, auto_diff" with different triggers accordingly.
Removed "auto_diff" from manual trigger, because the logic doesn't work. (Always override by inputs.)
Add presubmit(push) trigger, which run linux firestore with ccache.
presubmit check: without ccache 35 mins vs with ccache 18 mins
To understand different triggers.
TODO: Will add branch_protection_rules "build-desktop-ubuntu-latest-openssl" and "test-desktop-ubuntu-latest-openssl" after this PR get merged.
Will have a cache system which enable ccache in more cases.