Skip to content

Change Git tag of googletest to the 1.11.0 release. #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 6, 2021
Merged

Change Git tag of googletest to the 1.11.0 release. #676

merged 4 commits into from
Oct 6, 2021

Conversation

jonsimantov
Copy link
Contributor

This is already the version set in download_googletest.py, and is the
version that the integration tests have been built/tested with.

(Because the integration tests do some internal GoogleTest stuff, it's
risky to pin to the main branch.)

@jonsimantov
Change Git tag of googletest to the 1.11.0 release.
115cc7d 
This is already the version set in download_googletest.py, and is the
version that the integration tests have been built/tested with.

(Because the integration tests do some internal GoogleTest stuff, it's
risky to pin to the main branch.)
@google-cla google-cla bot added the cla: yes label Sep 23, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Sep 23, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Sep 23, 2021
@github-actions
Copy link

github-actions bot commented Sep 23, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit e961980
Last updated: Wed Oct 6 13:55 PDT 2021
View integration test log & download artifacts

Failures Configs
messaging [TEST] [ERROR] [Android] [macos] [android_target]

Add flaky tests to go/fpl-cpp-flake-tracker

sunmou99
sunmou99 approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@sunmou99 sunmou99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Two things that may be helpful. 1. add comments and let others know why we use "1.11.0" not "master". 2. If the git tag is likely to change in the future, make it a variable in CMake.

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Sep 23, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 23, 2021
@jonsimantov
Copy link
Contributor Author

  1. add comments and let others know why we use "1.11.0" not "master".
    Done.
  1. If the git tag is likely to change in the future, make it a variable in CMake.
    I don't think it will change any time soon - the only reason it changed from 1.10 to 1.11 is because Firestore started using an exception throwing test.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Sep 28, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Sep 28, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 28, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Sep 29, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Sep 29, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 29, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Oct 5, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Oct 5, 2021
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels Oct 5, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 5, 2021
@jonsimantov jonsimantov added skip-release-notes Skip release notes check and removed tests: failed This PR's integration tests failed. labels Oct 6, 2021
@jonsimantov jonsimantov enabled auto-merge (squash) October 6, 2021 18:32
@jonsimantov jonsimantov merged commit e961980 into main Oct 6, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Oct 6, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 6, 2021
@jonsimantov jonsimantov deleted the bugfix/pin-googletest branch November 1, 2021 18:32
@firebase firebase locked and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sunmou99 sunmou99 sunmou99 approved these changes

Assignees

@sunmou99 sunmou99

Labels
cla: yes skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @sunmou99