Remove LoadAdResult from new Admob. #723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DellaBitta
changed the title
jonsimantov
approved these changes
Nov 2, 2021
| @@ -186,6 +190,10 @@ class AdResult { | |||
| /// Gets the message describing the error. | |||
| const std::string& message() const; | |||
|
|
|||
| /// Gets the ResponseInfo if an loadAd error occurred, with a collection of | |||
There was a problem hiding this comment.
Will there always be a responseinfo? What if it's the situation where it wasn't, will it just be empty?
There was a problem hiding this comment.
Yes, the call to this method will return an emtpy ResponseInfo object.
There was a problem hiding this comment.
Updated the comments.
Base automatically changed from
feature/admob_2021_adview_listeners
to
feature/admob_2021
November 8, 2021 20:58
github-actions
bot
added
the
tests: in-progress
❌ Integration test FAILEDRequested by @DellaBitta on commit efda224
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove LoadAdResult and fold it's data into AdResult.
The ResponseInfo member of LoadAdResult now resides in AdResult and will only be populated in Results that stem from
loadAdrequests.Note: With this new class / data member topography, there isn't an order in which I could declare AdResult in types.h without the compiler complaining that it needed a definition of its ResponseInfo member. I solved this by making the member a pointer to a ResponseInfo and this made the compiler very happy. We're friends now.
Testing
Local testing on iOS and Android phones.
iTestRun
Type of Change
Place an
xthe applicable box:Notes
N/A.