Skip to content

RewardedAds for Android #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 16, 2021
Merged

RewardedAds for Android #741

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1fc8428
Android builds and runs. Desktop and iOS stubs.
DellaBitta Nov 9, 2021
4a5dabc
revamp Android C++ JNI method signatures
DellaBitta Nov 9, 2021
0a3c7d1
added admob/src/common/full_screen_ad_event_listener.cc/h
DellaBitta Nov 9, 2021
122a772
added ServerSideVerificationOptions
DellaBitta Nov 10, 2021
0485c81
lint fix
DellaBitta Nov 11, 2021
79ef124
Merge branch 'feature/admob_2021' into feature/admob_2021_android_rew…
DellaBitta Nov 11, 2021
32c1b62
lint fix - header order
DellaBitta Nov 11, 2021
10a3a4d
review fixes
DellaBitta Nov 15, 2021
f38cddb
bounding box checks fail on simulators due to aspect ratios
DellaBitta Nov 15, 2021
5a9ecfd
simulator itests
DellaBitta Nov 16, 2021
5a046c3
bounding box changes on sims
DellaBitta Nov 16, 2021
b9069da
stress tests
DellaBitta Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions admob/integration_test/src/integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,6 +937,9 @@ TEST_F(FirebaseAdMobTest, TestBannerView) {
bounding_box_listener.bounding_box_changes_.size());

#if defined(ANDROID) || TARGET_OS_IPHONE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of disabling this test, is it possible to just add some wiggle room to the aspect ratio check on simulator?

// Simulators have varying aspect ratios.
TEST_REQUIRES_USER_INTERACTION;

// As an extra check, all bounding boxes except the last should have the same
// size aspect ratio that we requested. For example if you requested a 320x50
// banner, you can get one with the size 960x150. Use EXPECT_NEAR because the
Expand Down