AdMob Rewarded Ads on iOS #752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsimantov
approved these changes
Nov 22, 2021
| RewardedAdInternalIOS::~RewardedAdInternalIOS() { | ||
| firebase::MutexLock lock(mutex_); | ||
| // Clean up any resources created in RewardedAdInternalIOS. | ||
| Mutex mutex(Mutex::kModeNonRecursive); |
There was a problem hiding this comment.
Is this the model we use for other things that block until the destruction is complete? Or do we use a Semaphore?
jonsimantov
reviewed
Nov 22, 2021
| } | ||
| mutex_in_block->Release(); | ||
| }; | ||
| util::DispatchAsyncSafeMainQueue(destroyBlock); |
There was a problem hiding this comment.
Since this is a pattern we've done before, I wonder if we should actually make a DispatchAsyncSafeMainQueueBlocking, and also add tests for it.
There was a problem hiding this comment.
I'm going to change this in the next PR which includes some other stability fixes.
github-actions
bot
added
the
tests: in-progress
❌ Integration test FAILEDRequested by @DellaBitta on commit dc996e0
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the iOS implement to be able to display rewarded ads.
Testing
Local testing with the itests on an iOS device.
iTest Ci
Type of Change
Place an
xthe applicable box: