AdMob AdRequest Neighboring Content URLS #769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DellaBitta
commented
Dec 1, 2021
| @@ -193,10 +194,14 @@ void ForEachAppDelegateClass(void (^block)(Class)); | |||
| NSMutableArray *StringVectorToNSMutableArray( | |||
| const std::vector<std::string> &vector); | |||
|
|
|||
| // Convert a unordered_set of strings into an NSMutableArray. | |||
| NSMutableArray *StringUnorderedSetToNSMutableArray( | |||
| const std::unordered_set<std::string> &set); | |||
There was a problem hiding this comment.
#include <unordered_set> is indeed at the top of the file.
DellaBitta
commented
Dec 1, 2021
| void NSArrayOfNSStringToVectorOfString(NSArray* array, | ||
| std::vector<std::string>* string_vector); | ||
| void NSArrayOfNSStringToVectorOfString( | ||
| NSArray *array, std::vector<std::string> *string_vector); |
There was a problem hiding this comment.
#include <vector> is indeed at the top of the file.
DellaBitta
changed the title
jonsimantov
reviewed
Dec 1, 2021
| @@ -120,6 +120,11 @@ static const char* kAdNetworkExtrasInvalidClassName = "abc123321cba"; | |||
|
|
|||
| static const char* kContentUrl = "http://www.firebase.com"; | |||
|
|
|||
| static const std::vector<std::string> kNeighboringContentURLs = { | |||
| "https://firebase.google.com/products-build", | |||
There was a problem hiding this comment.
Are these real URLs? should we use fake ones?
jonsimantov
approved these changes
Dec 3, 2021
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -193,10 +194,14 @@ void ForEachAppDelegateClass(void (^block)(Class)); | |||
| NSMutableArray *StringVectorToNSMutableArray( | |||
| const std::vector<std::string> &vector); | |||
|
|
|||
| // Convert a unordered_set of strings into an NSMutableArray. | |||
| NSMutableArray *StringUnorderedSetToNSMutableArray( | |||
| const std::unordered_set<std::string> &set); | |||
There was a problem hiding this comment.
Add #include <unordered_set> for unordered_set<>
| void NSArrayOfNSStringToVectorOfString(NSArray *array, | ||
| std::vector<std::string> *string_vector); | ||
| void NSArrayOfNSStringToVectorOfString( | ||
| NSArray *array, std::vector<std::string> *string_vector); |
There was a problem hiding this comment.
Add #include <vector> for vector<>
jonsimantov
reviewed
Dec 4, 2021
| @@ -24,6 +24,7 @@ | |||
|
|
|||
| #include <map> | |||
| #include <string> | |||
| #include <unordered_set> | |||
| #include <vector> | |||
|
|
|||
| #include "app/src/include/firebase/variant.h" | |||
There was a problem hiding this comment.
I think you can fix the lint error if you move the system #includes above the #ifdef __OBJC__.
github-actions
bot
added
the
tests: in-progress
❌ Integration test FAILEDRequested by @DellaBitta on commit dc62717
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to configure Neighboring Content URL strings to the AdRequest object.
Additionally renamed the parameter in the
AdRequest::add_extramethod fromadd_extra(const char* ad_network, …)toadd_extra(const char* adapter_class_name, … )to match nomenclature in the iOS and Android SDKs.Testing
Integration Tests CI
Type of Change
Place an
xthe applicable box: