Set the FIRESTORE_INCLUDE_OBJC cmake cache var to NO #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g Objective-C parts of the iOS SDK. This won't have any effects until the iOS dependencies are updated to a version that includes firebase/firebase-ios-sdk#9658. This will fix the following build error: ``` FIRFirestore.h:147:20: error: unknown attribute 'swift_async' ignored [-Werror,-Wunknown-attributes] __attribute__((swift_async(none))); // Disable async import due to #9426. ^ 1 error generated. ``` which was introduced by firebase/firebase-ios-sdk#9502. It avoids it by simply not building the file at all :)
dconeybe
requested review from
schmidt-sebastian
and removed request for
schmidt-sebastian
dconeybe
added
the
tests-requested: quick
github-actions
bot
added
the
tests: in-progress
❌ Integration test FAILEDRequested by @dconeybe on commit 665b2d5
Add flaky tests to go/fpl-cpp-flake-tracker |
github-actions
bot
removed
the
tests-requested: quick
schmidt-sebastian
approved these changes
Apr 16, 2022
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't have any effects until the iOS dependencies are updated to a version that includes firebase/firebase-ios-sdk#9658.
Setting the cmake cache variable
FIRESTORE_INCLUDE_OBJCtoNOwill work around theunknown attribute 'swift_async'build error introduced by firebase/firebase-ios-sdk#9502, and that will be picked up the next time that the iOS dependencies in this repository are upgraded. This fixes the build error because the file with the problematic code is no longer included in the build.See firebase/firebase-ios-sdk#9658 for more details.