-
Notifications
You must be signed in to change notification settings - Fork 124
Update to Firebase iOS SDK 9.0.0 with necessary changes for Swift support and Firestore #915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 79 commits
Commits
Show all changes
109 commits
Select commit
Hold shift + click to select a range
50fca51
Remove the patch to enable Snappy support
dconeybe 13222be
firestore_patch.py: also copy the URL_HASH
dconeybe 47a2562
query_main.h: fix build error due to Filter being renamed to FieldFil…
dconeybe fa99004
user_data_converter_main.cc: fix build error when calling NullValue()…
dconeybe 555a406
Merge in https://github.com/firebase/firebase-cpp-sdk/pull/896 (level…
dconeybe 2564279
leveldb_snappy_test.cc: re-use the test from the iOS SDK instead of r…
dconeybe 19e0b72
leveldb_snappy_test.cc: add a newline at the end of the file.
dconeybe 16605a9
query_main.h: add missing #include "Firestore/core/src/core/field_fil…
dconeybe 4e823e1
Set the FIRESTORE_INCLUDE_OBJC cmake cache var to NO to avoid buildin…
dconeybe 56553d9
external/pip_requirements.txt: add six
dconeybe c6346fd
Improve FIREBASE_PYTHON_EXECUTABLE cmake cache var and make its usage…
dconeybe 5a8038d
firestore.cmake: bump pinned commit
dconeybe b0ff4e8
Revert "external/pip_requirements.txt: add six" since it didn't fix t…
dconeybe 05efff1
firestore.cmake: fix pinned commit
dconeybe 48a7680
Revert "Improve FIREBASE_PYTHON_EXECUTABLE cmake cache var and make i…
dconeybe bd56ad5
firestore.cmake: update pinned commit
dconeybe 7e229e8
CMakeLists.txt: Set FIRESTORE_INCLUDE_OBJC as a cache variable so it …
dconeybe bf8bffd
query_main.cc: IsBefore(BoundPosition) -> IsInclusive(BoundPosition)
dconeybe 68c2a0f
Merge remote-tracking branch 'origin/main' into FirestorePrepForIosSd…
dconeybe 3de3838
firestore.cmake: update pinned commit
dconeybe c1f3e89
Use staging repo and update to 9.0 podfiles.
jonsimantov fc1e5fe
Remove streaming support, as it fails with the new Swift SDK.
jonsimantov 96e26be
Enable Firestore and Admob.
jonsimantov 33b232d
Remove AdMob for now - it's broken in 7.69.0-cppsdk.
jonsimantov 29deb4a
Don't process swift headers if already processed
jonsimantov 7113be3
fix nightly version tag
jonsimantov b5be326
Fix update dependencies script
jonsimantov 1097cd2
Support directories with spaces
jonsimantov 8587f54
Exclude swift headers from linter.
jonsimantov fd06e74
Fix whitespace
jonsimantov 9d7e4c7
Fix comma
jonsimantov c44adef
Fix whitespace.
jonsimantov a43089b
Merge branch 'main' into dconeybe/FirestorePrepForIosSdkM115
jonsimantov 020990b
Merge branch 'dconeybe/FirestorePrepForIosSdkM115' into other/test_io…
jonsimantov 60c1485
Fix Firestore external file.
jonsimantov bfc82c4
Restore new external file and fix include path.
jonsimantov 0085585
Fix include files and paths to be compatible with C++ build.
jonsimantov 725e2d4
Format code.
jonsimantov 0602b35
Add NOLINT
jonsimantov b78d97a
Remove included test with bad include path.
jonsimantov 19ee687
Fix internal test podfile
jonsimantov 1dbbe58
Fix podfiles
jonsimantov 12297f5
Merge remote-tracking branch 'origin/main' into test_ios_900_pods
dconeybe d3d051d
Revert some junk that got pulled in when #898 was merged into this br…
dconeybe 32aec7e
Temporarily remove admob from integration_tests.yml too.
dconeybe fc6b845
integration_tests.yml: remove admob from another place, since it stil…
dconeybe 581cb8d
Revert "integration_tests.yml: remove admob from another place, since…
dconeybe 00b4aac
Revert "Temporarily remove admob from integration_tests.yml too."
dconeybe 3780194
Add AdMob back in and refer to new version in staging.
jonsimantov 225c322
Merge branch 'other/test_ios_900_pods' of https://github.com/firebase…
jonsimantov d468fa7
Speed up update-dependencies zip distribution usage
jonsimantov 8e0d742
Fix substitution.
jonsimantov 565e4fc
Fix header formatting
jonsimantov abb771e
Fix spacing.
jonsimantov 5f3d83f
Update Xcode version to 12.5.1 and add tests to 13.2.1
jonsimantov 31a3a04
Add new version to readme
jonsimantov d693217
Change Functions iOS SDK and tvOS SDK version to 12.4 (minimum for Sw…
jonsimantov e30d0f4
Since FIRStorageMetadata no longer implements NSCopying, copy it a di…
jonsimantov 93c8d79
Change deployment version to 12.4 for Storage, required for Swift sup…
jonsimantov 2f93b66
Update analytics headers from 9.0.0 Analytics RC.
jonsimantov 06fd33d
Add note about removal of deprecated analytics constants.
jonsimantov 0b1cde8
Set analytics deployment target
jonsimantov 63133eb
Set deployment targets
jonsimantov 6315d32
Add empty Swift file to sample framework.
jonsimantov 373c9c8
Switch Podfile postprocessing to use python3
jonsimantov 1bc7910
Add empty Swift file to integration test project.
jonsimantov 85567be
Add empty Swift file to analytics project
jonsimantov 33fc564
Add empty.swift to remaining integration test projects.
jonsimantov e1e2ea0
Check to make sure that the controller can pause/resume/etc.
jonsimantov ad49def
Workaround for pause/cancel/resume semantics changing in 9.x.
jonsimantov 18ef469
Switch from nightly to release tag for Firestore external dep.
jonsimantov b56a26c
Update Xcode version to 13.2.1, required version for iOS SDK.
jonsimantov 42236c8
Change deployment target back to 10.x.
jonsimantov cb3deda
Fix iOS deployment version back to 10.0
jonsimantov 692f44d
Add notes about including a swift file
jonsimantov c72baab
Change comparison to lower-case to prevent restore_secrets overriding…
jonsimantov da53723
Clean up the verbose log of file size
jonsimantov b47fcf5
firestore_snappy.patch.txt: remove the patching for https://github.co…
dconeybe 94eb1a6
CHERRY PICK from main branch: leveldb_snappy_test.cc: run the test on…
dconeybe 412f8bd
Set block storage for task variable.
jonsimantov 4ae9370
Fix server key.
jonsimantov 5169d91
Merge branch 'other/test_ios_900_pods' of https://github.com/firebase…
jonsimantov 731eab8
Format code.
jonsimantov b6a5957
test iOS simulator devices
sunmou99 0c1b8d1
Windows compatibility for strcasecmp
jonsimantov a9f30f0
Merge branch 'other/test_ios_900_pods' of https://github.com/firebase…
jonsimantov c6d8c70
test iOS simulator devices
sunmou99 cfa878f
Update Swift header to include copy method; revert Storage to use it.
jonsimantov 80444e8
Merge branch 'other/test_ios_900_pods' of https://github.com/firebase…
jonsimantov e04d6a6
upload ios projects artifacts
sunmou99 2bda0ea
Merge branch 'other/test_ios_900_pods' of https://github.com/firebase…
jonsimantov 44c49b2
Temporarily disable a test that fails on device when built from cmdline.
jonsimantov 28672b7
Update the testing Xcode version to 13.3.1
a-maurice 4edb2f6
Change xcode version to 13.3.1 and macos runners to macos-12.
jonsimantov f1b5211
Merge branch 'update-runners-macos-12' into other/test_ios_900_pods
jonsimantov 699ac93
Merge branch 'main' into other/test_ios_900_pods
jonsimantov f68f159
Merge branch 'main' into other/test_ios_900_pods
jonsimantov a6fa7f5
Restore simulator versions back to previous values
jonsimantov 043bc1f
Reworded some release notes.
jonsimantov eb4b0d7
Revert "upload ios projects artifacts"
jonsimantov a0725a3
Fix Swift header script to work with multiple URLs.
jonsimantov f26dc40
Update Swift headers for final 9.0.0 release
jonsimantov 63637b4
Add readme about ios_pod directory and its swift_headers subdirectory
jonsimantov 433073d
Remove staging repo from podfiles. (#923)
jonsimantov e54659e
If the zip file can't be downloaded, just skip that step.
jonsimantov 9890483
Merge branch 'other/test_ios_900_pods' of https://github.com/firebase…
jonsimantov 6154880
Merge branch 'main' into other/test_ios_900_pods
jonsimantov a5ab644
Merge branch 'main' into other/test_ios_900_pods
jonsimantov 566e4d8
Merge branch 'main' into other/test_ios_900_pods
jonsimantov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,17 @@ | ||
source 'https://github.com/Firebase/SpecsStaging.git' | ||
source 'https://github.com/CocoaPods/Specs.git' | ||
platform :ios, '10.0' | ||
# Firebase AdMob test application. | ||
use_frameworks! :linkage => :static | ||
|
||
target 'integration_test' do | ||
pod 'Firebase/Analytics', '8.15.0' | ||
pod 'Google-Mobile-Ads-SDK', '7.69.0-cppsdk' | ||
pod 'Firebase/Analytics', '9.0.0' | ||
pod 'Google-Mobile-Ads-SDK', '7.69.0-cppsdk2' | ||
jonsimantov marked this conversation as resolved.
Show resolved
Hide resolved
|
||
end | ||
|
||
post_install do |installer| | ||
# If this is running from inside the SDK directory, run the setup script. | ||
system("if [[ -r ../../setup_integration_tests.py ]]; then python ../../setup_integration_tests.py .; fi") | ||
system("/usr/bin/python ./download_googletest.py") | ||
system("if [[ -r ../../setup_integration_tests.py ]]; then python3 ../../setup_integration_tests.py .; fi") | ||
system("python3 ./download_googletest.py") | ||
end | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,22 @@ | ||
source 'https://github.com/Firebase/SpecsStaging.git' | ||
source 'https://github.com/CocoaPods/Specs.git' | ||
platform :ios, '10.0' | ||
# Firebase Analytics test application. | ||
use_frameworks! :linkage => :static | ||
|
||
target 'integration_test' do | ||
platform :ios, '10.0' | ||
pod 'Firebase/Analytics', '8.15.0' | ||
pod 'Firebase/Analytics', '9.0.0' | ||
end | ||
|
||
target 'integration_test_tvos' do | ||
platform :tvos, '12.0' | ||
pod 'Firebase/Analytics', '8.15.0' | ||
pod 'Firebase/Analytics', '9.0.0' | ||
end | ||
|
||
post_install do |installer| | ||
# If this is running from inside the SDK directory, run the setup script. | ||
system("if [[ -r ../../setup_integration_tests.py ]]; then python ../../setup_integration_tests.py .; fi") | ||
system("/usr/bin/python ./download_googletest.py") | ||
system("if [[ -r ../../setup_integration_tests.py ]]; then python3 ../../setup_integration_tests.py .; fi") | ||
system("python3 ./download_googletest.py") | ||
end | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.