Skip to content

Use build OS variables instead of hard coded build OS names #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
May 5, 2022
Merged

Use build OS variables instead of hard coded build OS names #922

merged 20 commits into from
May 5, 2022

Conversation

sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented May 3, 2022 •
edited
Loading

Description

Use build OS variables instead of hard coded build OS names

Testing

Succeed:
https://github.com/firebase/firebase-cpp-sdk/actions/runs/2265168672

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@sunmou99 sunmou99 requested a review from jonsimantov May 3, 2022 17:36
@sunmou99 sunmou99 added the skip-release-notes Skip release notes check label May 3, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 3, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 3, 2022
@github-actions
Copy link

github-actions bot commented May 3, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @sunmou99 on commit 266456e
Last updated: Thu May 5 13:48 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FAILURE] [Linux] [openssl]
(1 failed tests)  FirestoreIntegrationTest.TestMetadataOnlyChangesAreNotFiredWhenNoOptionsProvided
[TEST] [FLAKINESS] [Android] [2/3 os: windows macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

Base automatically changed from update-runners-macos-12 to main May 3, 2022 18:07
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 3, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 3, 2022
@jonsimantov
Copy link
Contributor

Can you merge from main (and resolve the conflicts) before I review?

@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label May 4, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels May 4, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 5, 2022
jonsimantov
jonsimantov reviewed May 5, 2022
View reviewed changes
Copy link
Contributor

@jonsimantov jonsimantov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the integration test summary says everything succeeded, BUT the Android emulator tests failed. Any idea why it was still reported as success? I think I've seen this happen before when the emulator test fails.

https://github.com/firebase/firebase-cpp-sdk/actions/runs/2272273221

@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label May 5, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels May 5, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 5, 2022
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label May 5, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels May 5, 2022
@sunmou99
Copy link
Contributor Author

sunmou99 commented May 5, 2022

So, the integration test summary says everything succeeded, BUT the Android emulator tests failed. Any idea why it was still reported as success? I think I've seen this happen before when the emulator test fails.

https://github.com/firebase/firebase-cpp-sdk/actions/runs/2272273221

This is because we fail to locate the SDK artifacts, thus assuming it's a build error and ignore the test error.
This is a bug, and I fixed the artifacts path in the PR.

@sunmou99 sunmou99 requested a review from jonsimantov May 5, 2022 16:12
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 5, 2022
@sunmou99 sunmou99 enabled auto-merge (squash) May 5, 2022 17:38
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 5, 2022
@jonsimantov
Copy link
Contributor

Test failure seems unrelated, as far as I'm concerned this is good to merge.

@sunmou99 sunmou99 removed the tests: failed This PR's integration tests failed. label May 5, 2022
@sunmou99 sunmou99 merged commit 266456e into main May 5, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label May 5, 2022
@sunmou99 sunmou99 deleted the bugfix/github-runner branch May 5, 2022 18:12
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 5, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 5, 2022
@firebase firebase locked and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunmou99 @jonsimantov