Add geopoint support #105
Merged
Add geopoint support #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehan
approved these changes
Jul 14, 2021
| expect(snapshot.data()).to.deep.equal({ geopoint: hq }); | ||
| }); | ||
|
|
||
| it('should allow timestmaps with makeDocumentSnapshot', () => { |
| @@ -29,4 +30,47 @@ describe('providers/firestore', () => { | |||
| expect(snapshot.data()).to.deep.equal(undefined); | |||
| expect(snapshot.id).to.equal('doc-id'); | |||
| }); | |||
|
|
|||
| it('should allow geopoints with makeDocumentSnapshot', () => { | |||
| const test = fft(); | |||
There was a problem hiding this comment.
Optional - could get rid of this line thats repeated in every test cases and use a before/beforeEach instead
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47
Looked into other reports that there are issues serializing a document reference or a timestamp. Added tests to verify that these actually work (though the types are a bit harder to work with).