-
Notifications
You must be signed in to change notification settings - Fork 59
Support for scheduled functions #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@laurenzlong this seems like a reasonable thing to do, but I'm not as familiar with the codebase to know if this is the reasonable way to do it. Can you take a look? |
Just to note I'm not really up to scratch with TypeScript so I have no idea if the way I've changed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good so far! Thanks for the contributions! It could use a bit of refactoring, but the implementation is correct otherwise.
5b41c0f
to
5d6d03f
Compare
@laurenzlong sorry for the delay. I rebased from master and ran the new prettifier and then implemented the change you requested. |
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
cbf5bf1
to
90980fa
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
90980fa
to
a622f1c
Compare
@laurenzlong / @mbleigh is it possible to get this reviewed and merged in - thanks! |
@rhodgkins thanks for the reminder! Sorry I missed the updates. Thanks again for the contribution! This will be in the 0.2.0 release. |
Thanks @laurenzlong - any ideas when v0.2.0 will be released? |
We're working on a new release process so it'll be a few days but hopefully not longer than that. |
@rhodgkins It's released now! |
Description
Adds support for scheduled functions that use only the
context
parameter when called.Also includes tests.
Code sample