Support null value in makeDataSnapshot and update dependencies #53
Conversation
laurenzlong
changed the title
spec/index.spec.ts
Outdated
| @@ -21,11 +21,11 @@ | |||
| // SOFTWARE. | |||
|
|
|||
| import 'mocha'; | |||
| import { expect } from 'chai'; | |||
| import {expect} from 'chai'; | |||
There was a problem hiding this comment.
So, it looks like the rest of this repo has spaces around single element { objects } - for example, https://github.com/firebase/firebase-functions-test/blob/master/src/index.ts#L24. Firebase-tools also keeps this style: https://github.com/firebase/firebase-tools/blob/master/src/commands/apps-list.ts#L5
I think your linter might have broken this throughout the files in this PR - can you switch this back?
| it('produces the right snapshot with makeDataSnapshot', async () => { | ||
| const snapshot = makeDataSnapshot({ | ||
| foo: 'bar', | ||
| }, 'path'); |
There was a problem hiding this comment.
Nit - add a newline after this to separate the act and assert steps of this test.
| }); | ||
|
|
||
| it('should allow null value in makeDataSnapshot', async () => { | ||
| const snapshot = makeDataSnapshot(null, 'path'); |
There was a problem hiding this comment.
Nit - add a newline after this line to separate the act and assert steps of this test.
|
|
||
| describe('providers/firestore', () => { | ||
| it('produces the right snapshot with makeDocumentSnapshot', async () => { | ||
| const test = fft(); |
There was a problem hiding this comment.
Nit - add a newline after this line and after you call makeDocumentSnapshot, to split up the arrange ,act, and assert steps of this test
| }); | ||
|
|
||
| it('should allow empty document in makeDocumentSnapshot', async () => { | ||
| const test = fft(); |
There was a problem hiding this comment.
Nit - add a newline after this line and after you call makeDocumentSnapshot, to split up the arrange ,act, and assert steps of this test
Description
Add support for null value in data snapshot (#48), added unit tests for creating Firestore DocumentSnapshot and RTDB DataSnapshot, also updated dependencies to more modern versions. (Note: peer dependencies are updated less aggressively than dev dependencies, since dev dependencies are what a contributor of this library must install, whereas peer dependencies are what users of this library must use)
Code sample