Support rawRequest in callable context #54
Conversation
spec/providers/https.spec.ts
Outdated
| @@ -1,45 +1,72 @@ | |||
| import { expect } from 'chai'; | |||
| import {expect} from 'chai'; | |||
There was a problem hiding this comment.
So, it looks like the rest of this repo has spaces around { objects } - for example, https://github.com/firebase/firebase-functions-test/blob/master/src/index.ts#L24. Firebase-tools also keeps this style: https://github.com/firebase/firebase-tools/blob/master/src/commands/apps-list.ts#L5
I think your linter might have broken this throughout the files in this PR - can you switch this back?
There was a problem hiding this comment.
Yes it did... I had the wrong VSCode settings.... thanks for catching.
spec/providers/https.spec.ts
Outdated
| }); | ||
| it('should run the wrapped onCall function and return result', async () => { | ||
| const test = fft(); | ||
| const result = await test.wrap(cfToUpperCaseOnCall)({message: 'lowercase'}); |
There was a problem hiding this comment.
Nit - add a newline after this line and after you call test.wrap, to split up the arrange ,act, and assert steps of this test
| expect(result).to.deep.equal({msg: 'LOWERCASE', from: 'abc'}); | ||
| it('should accept auth params', async () => { | ||
| const test = fft(); | ||
| const options = {auth: {uid: 'abc'}}; |
There was a problem hiding this comment.
Nit - add a newline after this line and after you call test.wrap, to split up the arrange ,act, and assert steps of this test
| const test = fft(); | ||
| const options = { | ||
| rawRequest: mockRequest, | ||
| }; |
There was a problem hiding this comment.
Nit - add a newline after this line and after you call test.wrap, to split up the arrange ,act, and assert steps of this test
|
@joehan Fixed. PTAL |
|
Oh, actually I see you already approved. Thanks! |
Description
Resolves #41
Code sample