Add Http status check to Realtime stream #10406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
karenyz
reviewed
Nov 8, 2022
| [self pauseRealtimeStream]; | ||
| [self retryHTTPConnection]; | ||
| if ([self isStatusCodeRetryable:statusCode]) { |
There was a problem hiding this comment.
for cases where we don't retry, should we return an error to the client?
There was a problem hiding this comment.
Yeah it'd make sense to return a StreamError if we can't retry, updated.
karenyz
approved these changes
Nov 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks HTTP status before retrying. Matching Android PR: firebase/firebase-android-sdk#4121
Ok 200
Client Timeout 408
Bad Gateway 502
Unavailable 503
Gateway timeout 504
Changes timeout connection to 5 and a half minutes.