Skip to content

[AppCheck] Fix AppCheck interference for apps using ARCore and Firebase #12191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Dec 13, 2023

No description provided.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It does look safe to do an SPM-only 10.19.1 release from master. The only rough piece would be temporarily updating the version in Package.swift.

Testing should include a copybara and global tap for FirebaseCore

@ncooke3
Copy link
Member Author

ncooke3 commented Dec 13, 2023

@paulb777, thanks for reviewing and the plan sounds good. I will merge now and kick off the copybara & global tap, but I won't proceed with any releasing until tomorrow.

@ncooke3 ncooke3 merged commit 25fcae9 into master Dec 13, 2023
@ncooke3 ncooke3 deleted the nc/fac-multi-app-fix branch December 13, 2023 04:15
@firebase firebase locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants