Use new filesystem routines in FSTLevelDB #1707
Conversation
Also rework -[FSTPersistence start] to return Status
| namespace { | ||
|
|
||
| FirestoreErrorCode ConvertStatusCode(const leveldb::Status& status) { | ||
| if (status.ok()) return FirestoreErrorCode::Ok; |
There was a problem hiding this comment.
Alternative would be to switch on status.code(). You could then use the compiler to help enforce exhaustive checks. Optional.
Edit: Oops. status.code() is private. I guess we'll just have to hope leveldb never adds any new error types. :(
There was a problem hiding this comment.
That's where I started, and yes code() is private. There's equivalent code in google3 so I think this is about as good as it gets for now.
| NSString *dotPrefixed = [@"." stringByAppendingString:kReservedPathComponent]; | ||
| return [NSHomeDirectory() stringByAppendingPathComponent:dotPrefixed]; | ||
| std::string dotPrefixed = absl::StrCat(".", kReservedPathComponent); | ||
| return Path::FromNSString(NSHomeDirectory()).AppendUtf8(dotPrefixed); |
There was a problem hiding this comment.
Completely unrelated to your change, I don't think Apple recommends putting stuff like this directly in the homedir anymore. (xdg doesn't either.)
No action required.
There was a problem hiding this comment.
Yep. Fixing this is something we should do as a part of macOS support.
This is a stepping stone toward moving most of FSTLevelDB to C++. This PR focuses mostly on rearranging the callers of
-[FSTPersistence start]to useutil::Statusand moves the guts to C++ where possible.