Skip to content

Clean up warnings in leveldb_transaction.cc #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2018
Merged

Clean up warnings in leveldb_transaction.cc #1711

merged 1 commit into from
Aug 17, 2018

Conversation

wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Aug 17, 2018 •
edited
Loading

  • absl::string_view should be passed by value
  • use absl::StrCat and friends for concatenation
  • use C++11 range-based for loops
  • avoid sign conversion

@wilhuff
Clean up warnings in leveldb_transaction.cc
d3a01a9 
  * absl::string_view should be passed by value
  * use absl::StrCat and friends for concatenation
  * use C++11 range-based for loops
  * avoid sign conversion
@wilhuff wilhuff requested a review from gsoltis August 17, 2018 19:09
@gsoltis gsoltis assigned wilhuff and unassigned gsoltis Aug 17, 2018
@wilhuff wilhuff merged commit d90596c into master Aug 17, 2018
@wilhuff wilhuff deleted the wilhuff/leveldb-transaction branch August 17, 2018 19:46
@firebase firebase locked and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gsoltis gsoltis gsoltis approved these changes

Assignees

@wilhuff wilhuff

Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wilhuff @gsoltis @googlebot