Skip to content

Invalidate sessions in completion handlers #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

morganchen12
Copy link
Contributor

@morganchen12 morganchen12 commented Oct 9, 2018

Fixes #1917, presumably fixes #1892. Sessions are invalidated on completion and error.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Presumably, it also fixes #1892?

@morganchen12
Copy link
Contributor Author

Edited description to add 1892.

@morganchen12 morganchen12 merged commit eb5ee22 into firebase:master Oct 9, 2018
morganchen12 added a commit to morganchen12/firebase-ios-sdk that referenced this pull request Oct 11, 2018
This reverts commit eb5ee22, reversing
changes made to 4fa5c7b.
paulb777 pushed a commit that referenced this pull request Oct 11, 2018
@firebase firebase locked and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak in GULNetworkURLSession Firebase.configure() leaks
3 participants