Add Xcode 10 travis testing #1932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulb777 , there are two references to iPad Air in the testing script. |
ryanwilson
approved these changes
Oct 12, 2018
scripts/build.sh
Outdated
| @@ -231,25 +231,41 @@ case "$product-$method-$platform" in | |||
| ;; | |||
|
|
|||
| InAppMessagingDisplay-xcodebuild-iOS) | |||
| # Run UI tests on both iPad and iphone simultors | |||
| # Run UI tests on both iPad and iphone simulators | |||
scripts/build.sh
Outdated
| @@ -231,25 +231,41 @@ case "$product-$method-$platform" in | |||
| ;; | |||
|
|
|||
| InAppMessagingDisplay-xcodebuild-iOS) | |||
| # Run UI tests on both iPad and iphone simultors | |||
| # Run UI tests on both iPad and iphone simulators | |||
| # TODO: Running two destinations from one xcodebuild command stopped working with XCode 10. | |||
scripts/build.sh
Outdated
| build \ | ||
| test | ||
|
|
||
| cd InAppMessagingDisplay/Example | ||
| sed -i -e 's/use_frameworks/\#use_frameworks/' Podfile | ||
| pod update --no-repo-update | ||
| cd ../.. | ||
| # Run UI tests on both iPad and iphone simultors | ||
| # Run UI tests on both iPad and iphone simulators |
ulukaya
approved these changes
Oct 12, 2018
mylyuic
reviewed
Oct 12, 2018
| build \ | ||
| test | ||
|
|
||
| RunXcodebuild \ |
There was a problem hiding this comment.
this line seems not aligned with line on 237
| build \ | ||
| test | ||
|
|
||
| RunXcodebuild \ |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.