gRPC: add the ability to use a custom SSL certificate in integration tests #1942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxu123
approved these changes
Oct 15, 2018
rsgowman
reviewed
Oct 15, 2018
| grpc::InsecureChannelCredentials()); | ||
| } | ||
|
|
||
| std::fstream cert_file{test_credentials_->certificate_path}; |
| test_credentials_ = new TestCredentials{}; | ||
| } | ||
|
|
||
| test_credentials_->certificate_path = certificate_path.data(); |
There was a problem hiding this comment.
I don't think this is safe? string_view::data() isn't guaranteed to be null terminated, and I think std::string's operator= assumes the pointer is.
Maybe:
test_credentials_->certificate_path = std::string(cert_path.data(), cert_path.size());
Also immediately below.
rsgowman
approved these changes
Oct 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closely mimics the way it is currently done in Objective-C gRPC client by simply using a static string that contains a file path.