-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Invalidate non-background url sessions #2061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
be1dfc2
to
97745d5
Compare
97745d5
to
1c89842
Compare
|
I've seen that message when there's extra files in the repo, but it still successfully runs. Check |
The change looks good to me assuming it clears travis and internal tests. Let's also get a review from @ryanwilson |
Seems reasonable to me, please make sure this is tested via the repro steps from #2060 |
Tested manually, leaks went away. |
I'm worried this solution is insufficient for instances of
GULNetworkURLSession
that kick off multiple requests simultaneously since the_URLSession
ivar will be overridden.Changes mirrored at cr/220718996