Skip to content

Invalidate non-background url sessions #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 12, 2018

Conversation

morganchen12
Copy link
Contributor

@morganchen12 morganchen12 commented Nov 8, 2018

I'm worried this solution is insufficient for instances of GULNetworkURLSession that kick off multiple requests simultaneously since the _URLSession ivar will be overridden.

Changes mirrored at cr/220718996

@morganchen12
Copy link
Contributor Author

style.sh fails with an unclear error message.

morganchen-macbookpro:firebase-ios-sdk morganchen$ scripts/style.sh 
No such file or directory
No such file or directory

@paulb777
Copy link
Member

paulb777 commented Nov 8, 2018

I've seen that message when there's extra files in the repo, but it still successfully runs. Check git status to see if any files got updated.

@paulb777
Copy link
Member

paulb777 commented Nov 8, 2018

The change looks good to me assuming it clears travis and internal tests. Let's also get a review from @ryanwilson

@paulb777 paulb777 requested a review from ryanwilson November 8, 2018 23:54
@morganchen12 morganchen12 changed the title Invalidate non-pbackground url sessions Invalidate non-background url sessions Nov 8, 2018
@ryanwilson
Copy link
Member

Seems reasonable to me, please make sure this is tested via the repro steps from #2060

@paulb777
Copy link
Member

paulb777 commented Nov 9, 2018

@morganchen12 morganchen12 merged commit 3dbcead into firebase:master Nov 12, 2018
@morganchen12 morganchen12 deleted the gulchangelist branch November 12, 2018 21:00
@morganchen12
Copy link
Contributor Author

Tested manually, leaks went away.

@paulb777 paulb777 mentioned this pull request Nov 13, 2018
@firebase firebase locked and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants