-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Functions Interop #2113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functions Interop #2113
Changes from 11 commits
4fadca3
04d62a2
06363ec
c56108d
d5537f8
09fcfa8
025b2f9
333abfb
15612c4
4f2291c
d4b020c
ba705ae
92104bc
5531040
c9dc765
637b3c8
95e42b9
487c518
60d69ff
19b7b6e
7ef5b7f
9e81f27
0c67063
ed91197
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ | |
|
||
#import <XCTest/XCTest.h> | ||
|
||
#import "FIRAuthInteropFake.h" | ||
#import "FIRError.h" | ||
#import "FIRFunctions+Internal.h" | ||
#import "FIRFunctions.h" | ||
|
@@ -31,7 +32,10 @@ @implementation FIRIntegrationTests | |
- (void)setUp { | ||
[super setUp]; | ||
id app = [[FUNFakeApp alloc] initWithProjectID:@"functions-integration-test"]; | ||
_functions = [FIRFunctions functionsForApp:app]; | ||
_functions = [[FIRFunctions alloc] | ||
bstpierr marked this conversation as resolved.
Show resolved
Hide resolved
|
||
initWithApp:app | ||
region:@"my-region" | ||
auth:[[FIRAuthInteropFake alloc] initWithToken:nil userID:nil error:nil]]; | ||
[_functions useLocalhost]; | ||
} | ||
|
||
|
@@ -77,7 +81,10 @@ - (void)testScalar { | |
- (void)testToken { | ||
// Recreate _functions with a token. | ||
id app = [[FUNFakeApp alloc] initWithProjectID:@"functions-integration-test" token:@"token"]; | ||
FIRFunctions *functions = [FIRFunctions functionsForApp:app]; | ||
FIRFunctions *functions = [[FIRFunctions alloc] | ||
initWithApp:app | ||
region:@"my-region" | ||
auth:[[FIRAuthInteropFake alloc] initWithToken:nil userID:nil error:nil]]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't understand why this passes. Shouldn't functions be using the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm also unsure how this was passing. It looks like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually, I bet it wasn't passing. Travis doesn't run the integration tests on PRs, just the master branch. I'll run them locally to make sure they're passing now. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm having difficulty running the integration tests. I get many warnings when running There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I changed my system to node 8, and ran through the suggestions it printed out, and it seems as though it's connecting to the emulator, but I'm not sure it's behaving as expected. For example, the From the emulator's output, it looks like Switching the tests to using Are the integration tests expected to pass? I'm not sure how they would on master without the region change and the duplicate There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It appears as though the last green run of master compiled the integration tests, but only ran the unit tests. It seems as though the integration tests aren't being run on Travis. I'll open an internal bug to fix and enable theses. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Yes, the shell script in Backend/ that installs the functions says to install them in |
||
[functions useLocalhost]; | ||
|
||
XCTestExpectation *expectation = [[XCTestExpectation alloc] init]; | ||
|
Uh oh!
There was an error while loading. Please reload this page.