Fix build under linux/gcc #2116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grpc_stream_tester.cc relies on f:f:model::DatabaseId, but wasn't depending on it within the cc_library f_f_remote_test_util rule, causing the build to fail. (Presumably, a mac specific library indirectly pulls this in.)
bstpierr
added a commit
that referenced
this pull request
Nov 27, 2018
* Revert "Custom fdl domain (#2121)" This reverts commit ebea1ef. * Revert "enable disabled passed integration test (#2120)" This reverts commit 48e5f7a. * Revert "Wire together LRU GC (#1905)" This reverts commit 305f872. * Revert "Fix build under linux/gcc (#2116)" This reverts commit b0a4b6c. * Revert "Implement PatchMutation::ApplyToLocalView (#1973)" This reverts commit f66b5b5. * Revert "Add Firebase Source to Header Search Path (#2114)" This reverts commit 0540361.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpc_stream_tester.cc relies on f:f:model::DatabaseId, but wasn't
depending on it within the cc_library f_f_remote_test_util rule, causing
the build to fail. (Presumably, a mac specific library indirectly pulls
this in.)