Skip to content

Make fuzzing less verbose to avoid exceeding Travis log limit #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Make fuzzing less verbose to avoid exceeding Travis log limit #2126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion scripts/fuzzing_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ readonly EXIT_FAILURE=1
# Get day of the year to use it when selecting a main target.
readonly DOY="$(date +%j)"

# How many last lines of the log to output for a failing job. This is to avoid
# exceeding Travis log size limit (4 Mb).
readonly LINES_TO_OUTPUT=500

# Run fuzz testing only if executing on xcode >= 9 because fuzzing requires
# Clang that supports -fsanitize-coverage=trace-pc-guard.
xcode_version="$(xcodebuild -version | head -n 1)"
Expand Down Expand Up @@ -110,7 +114,8 @@ for i in "${!all_fuzzing_targets[@]}"; do
echo "Error: Fuzz testing for target ${fuzzing_target} failed."
script_return=${EXIT_FAILURE}
echo "Fuzzing logs:"
echo "${fuzzing_results}"
echo "${fuzzing_results}" | tail -n${LINES_TO_OUTPUT}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat related question: The output here is generated by the run_xcode_fuzzing function, which calls xcodebuild. Clearly, it generates stdout, which we assign to this variable. Does it also generate stderr? If so, we might still end up with an overly long log.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it generates stderr -- at the very least, I could see a significant reduction in log length when running locally. I'd prefer to submit as is and do a followup.

echo "End fuzzing logs"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helps distinguish where the logs from the next test run start.

fi
done

Expand Down