Skip to content

Treat ABORTED writes as retryable #2247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2019
Merged

Treat ABORTED writes as retryable #2247

merged 2 commits into from
Jan 11, 2019

Conversation

wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Jan 10, 2019

This corresponds to a server-side change that will be released for the v1 protocol only (see b/119437764).

This is a port of firebase/firebase-js-sdk#1456.

@wilhuff wilhuff requested a review from mikelehen January 10, 2019 19:27
mikelehen
mikelehen approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikelehen mikelehen assigned wilhuff and unassigned mikelehen Jan 11, 2019
@wilhuff wilhuff merged commit 4e5c6d0 into master Jan 11, 2019
@wilhuff wilhuff deleted the wilhuff/aborted branch January 11, 2019 20:10
@firebase firebase locked and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

Assignees

@wilhuff wilhuff

Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wilhuff @mikelehen @googlebot