Skip to content

Fix build warning #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2019
Merged

Fix build warning #2661

merged 1 commit into from
Mar 27, 2019

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Mar 27, 2019 •
edited
Loading

Fix a missing comma build warning that's an error in internal build system.

Confirmed to remove warning and fix blaze build.

@paulb777 paulb777 requested review from dmandar, morganchen12 and maksymmalyhin and removed request for morganchen12 March 27, 2019 21:41
dmandar
dmandar approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@dmandar dmandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulb777 paulb777 merged commit f6747f7 into master Mar 27, 2019
@paulb777 paulb777 deleted the pb-dl-warning branch March 27, 2019 22:15
Corrob pushed a commit that referenced this pull request Apr 25, 2019
@paulb777 @Corrob
Fix build warning (#2661)
a0c6da2
@firebase firebase locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dmandar dmandar dmandar approved these changes

@maksymmalyhin maksymmalyhin Awaiting requested review from maksymmalyhin

Assignees
No one assigned
Labels
api: dynamiclinks cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @dmandar @googlebot