Add tvOS support to Firestore #2662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Force C99/C++11 * Use shared test info.plist * Remove CODE_SIGN_IDENTITY
* Remove code signing * Force C99/C++11 * Adjust plist file for new location * header search paths * LDFLAGS
Add tvos deployment targets to local pods
paulb777
approved these changes
Mar 28, 2019
Corrob
pushed a commit
that referenced
this pull request
Apr 25, 2019
* Create tvOS host app
* Standard project edits
* Remove code signing
* Force C99/C++11
* Adjust plist file for new location
* header search paths
* LDFLAGS
* Add Firestore_{Tests,IntegrationTests}_tvOS
* Add tvOS tests to the Podfile
* Add Firestore tvOS xcodebuild to build.sh
* Teach sync_project to keep tvOS up-to-date
* Add Firestore tvOS to Travis
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is everything in one swell foop.
Note the DIFFBASE on #2660. Once that merges I'll retarget on master and that will trigger a travis run.