Skip to content

Move collectionGroup method out of the Internal category #2802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2019

Conversation

wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Apr 10, 2019

This fixes a warning added by #2786.

This prevents a warning for end users.
@wilhuff
Copy link
Contributor Author

wilhuff commented Apr 10, 2019

@paulb777 @davidair This is a candidate for a cherry-pick into the M47 release branch.

@paulb777
Copy link
Member

The branch won't be made until tomorrow, so everything in master is still going in.

Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. 😦

@mikelehen mikelehen assigned wilhuff and unassigned mikelehen Apr 10, 2019
@wilhuff wilhuff merged commit 47bd60a into master Apr 11, 2019
@wilhuff wilhuff deleted the wilhuff/cg-category branch April 11, 2019 00:32
Corrob pushed a commit that referenced this pull request Apr 25, 2019
@firebase firebase locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants