Skip to content

Testing travis #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Testing travis #2811

merged 1 commit into from
Apr 11, 2019

Conversation

wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Apr 11, 2019

No description provided.

@wilhuff wilhuff self-assigned this Apr 11, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@wilhuff wilhuff requested a review from mikelehen April 11, 2019 18:18
@wilhuff wilhuff assigned mikelehen and unassigned wilhuff Apr 11, 2019
@wilhuff wilhuff changed the base branch from master to firestore-master April 11, 2019 18:19
@mikelehen mikelehen assigned wilhuff and unassigned mikelehen Apr 11, 2019
@wilhuff wilhuff merged commit 279a095 into firestore-master Apr 11, 2019
@wilhuff wilhuff deleted the wilhuff/test-travis branch April 11, 2019 18:20
wilhuff added a commit that referenced this pull request Apr 12, 2019
Corrob pushed a commit that referenced this pull request Apr 25, 2019
Corrob pushed a commit that referenced this pull request Apr 25, 2019
@firebase firebase locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants