Skip to content

Refactor Filters #3359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 20, 2019
Merged

Refactor Filters #3359

merged 15 commits into from
Jul 20, 2019

Conversation

wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Jul 15, 2019 •
edited by var-const
Loading

This consists of:

@wilhuff wilhuff requested a review from thebrianchen July 15, 2019 21:06
@wilhuff wilhuff force-pushed the wilhuff/refactor-filters branch from 246053c to 54030f5 Compare July 15, 2019 21:24
thebrianchen
thebrianchen approved these changes Jul 15, 2019
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spiritual LGTM

@wilhuff wilhuff requested a review from var-const July 16, 2019 14:13
@wilhuff wilhuff assigned var-const and unassigned thebrianchen Jul 16, 2019
@wilhuff
Copy link
Contributor Author

wilhuff commented Jul 16, 2019

@var-const Could you review for C++?

var-const
var-const reviewed Jul 16, 2019
View reviewed changes
Copy link
Contributor

@var-const var-const left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to port the spec test (EDIT: and the serializer test) from #1913 as well?

@var-const var-const assigned wilhuff and unassigned var-const Jul 16, 2019
@wilhuff wilhuff assigned var-const and unassigned wilhuff Jul 20, 2019
@var-const var-const assigned wilhuff and unassigned var-const Jul 20, 2019
@wilhuff wilhuff merged commit 05e734b into master Jul 20, 2019
@wilhuff wilhuff deleted the wilhuff/refactor-filters branch July 20, 2019 21:03
@firebase firebase locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

@var-const var-const var-const approved these changes

Assignees

@wilhuff wilhuff

Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wilhuff @thebrianchen @var-const @googlebot