Add isEqual() and port DocumentReference array test. #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikelehen
commented
Oct 16, 2017
mikelehen
commented
- Ports the test for the fix I made for Android for DocumentReference objects in arrays (bug not present in iOS).
- Implements isEqual on FIRQuery and FIRDocumentReference.
wilhuff
approved these changes
Oct 18, 2017
| @@ -110,6 +110,32 @@ - (instancetype)initWithKey:(FSTDocumentKey *)key firestore:(FIRFirestore *)fire | |||
| return self; | |||
| } | |||
|
|
|||
| #pragma mark - NSObject Methods | |||
|
|
|||
| - (BOOL)isEqual:(id)other { | |||
| return [self isEqualToReference:other]; | ||
| } | ||
|
|
||
| - (BOOL)isEqualToReference:(FIRDocumentReference *)reference { |
There was a problem hiding this comment.
nullable FIRDocumentReference *
Firestore/Source/API/FIRQuery.m
Outdated
| @@ -103,6 +103,31 @@ - (instancetype)initWithQuery:(FSTQuery *)query firestore:(FIRFirestore *)firest | |||
| return self; | |||
| } | |||
|
|
|||
| #pragma mark - NSObject Methods | |||
|
|
|||
| - (BOOL)isEqual:(id)other { | |||
There was a problem hiding this comment.
nullable here and in isEqualToQuery
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
* Ports the test for the fix I made for Android for DocumentReference objects in arrays (bug not present in iOS). * Implements isEqual on FIRQuery and FIRDocumentReference.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.