Port of fix for b/67042460 (retry more often before considering client offline) #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t offline) This ensures FSTRemoteStore always tries to connect at least twice before surfacing an FSTOnlineStateFailed event to external code (which may trigger gets to fail, cached data to be surfaced, etc.).
wilhuff
approved these changes
Oct 23, 2017
| @@ -98,6 +106,9 @@ - (instancetype)initWithLocalStore:(FSTLocalStore *)localStore | |||
| */ | |||
| @property(nonatomic, assign) FSTOnlineState watchStreamOnlineState; | |||
|
|
|||
| /** A count of consecutive failures to open the stream. */ | |||
| @property(nonatomic, assign) NSUInteger watchStreamFailures; | |||
There was a problem hiding this comment.
We should stick with avoiding these types unless we specifically need to interoperate with platform APIs that require their use. We should also avoid unsigned types unless we specifically need them: failure is very hard to detect.
Why not int?
There was a problem hiding this comment.
Sorry, I copypasta'd NSUInteger from kMaxPendingWrites. I fixed that and the 2 usages I added.
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
…t offline) (firebase#403) This ensures FSTRemoteStore always tries to connect at least twice before surfacing an FSTOnlineStateFailed event to external code (which may trigger gets to fail, cached data to be surfaced, etc.).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures FSTRemoteStore always tries to connect at least twice before surfacing an FSTOnlineStateFailed event to external code (which may trigger gets to fail, cached data to be surfaced, etc.).