Skip to content

Update Spec test protos #4814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2020
Merged

Update Spec test protos #4814

merged 1 commit into from
Feb 4, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

var-const
var-const approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@var-const var-const left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume it's okay that all versions are increased? I guess the generator code could check for zero explicitly.

@schmidt-sebastian
Copy link
Contributor Author

I presume it's okay that all versions are increased? I guess the generator code could check for zero explicitly.

Yes. It doesn't make much of a difference, as long as there is no zero version.

@schmidt-sebastian schmidt-sebastian merged commit d80ccb0 into master Feb 4, 2020
@firebase firebase locked and limited conversation to collaborators Mar 6, 2020
@paulb777 paulb777 deleted the mrschmidt/updatespecs branch July 9, 2020 00:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@var-const var-const var-const approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @var-const @googlebot