Change FServerValues to just-in-time read from SyncTrees. #5183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly. In order to pass this check, please resolve this problem and then comment ℹ️ Googlers: Go here for more info. |
inlined
force-pushed
the
increment-master
branch
from
adbd038 to
64e697b
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
schmidt-sebastian
approved these changes
Mar 25, 2020
| serverValues: | ||
| (NSDictionary *)serverValues; | ||
| + (id<FNode>)resolveDeferredValueSnapshot:(id<FNode>)node | ||
| withSyncTree:(id<FNode>)existing |
inlined
force-pushed
the
increment-master
branch
from
64e697b to
ddb1177
Compare
Based on fix firebase/firebase-js-sdk#2499 to bug firebase/firebase-js-sdk#2487 Micro-benchmarking showed that N writes in succession led to N^2 performance when calcuating the resolved write tree for those writes (thankfully only at the subpath in this SDK). This change matches the optimization in JS that mitigated a 20% performance regression.
inlined
force-pushed
the
inlined.increment-optimization
branch
from
74f9210 to
e0360a9
Compare
inlined
added a commit
that referenced
this pull request
Apr 1, 2020
* Change FServerValues to just-in-time read from SyncTrees. Based on fix firebase/firebase-js-sdk#2499 to bug firebase/firebase-js-sdk#2487 Micro-benchmarking showed that N writes in succession led to N^2 performance when calcuating the resolved write tree for those writes (thankfully only at the subpath in this SDK). This change matches the optimization in JS that mitigated a 20% performance regression. * Rename types to match JS sdk
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on fix firebase/firebase-js-sdk#2499 to bug firebase/firebase-js-sdk#2487
Micro-benchmarking showed that N writes in succession led to N^2 performance when calcuating the resolved write tree for those writes (thankfully only at the subpath in this SDK). This change matches the optimization in JS that mitigated a 20% performance regression.