Make RemoveSnapshotsInSyncListener run on the async queue #5632
Conversation
Generated by 🚫 Danger |
| @@ -499,7 +499,9 @@ void FirestoreClient::AddSnapshotsInSyncListener( | |||
|
|
|||
| void FirestoreClient::RemoveSnapshotsInSyncListener( | |||
| const std::shared_ptr<EventListener<Empty>>& user_listener) { | |||
| event_manager_->RemoveSnapshotsInSyncListener(user_listener); | |||
| worker_queue_->Enqueue([this, user_listener] { | |||
| event_manager_->RemoveSnapshotsInSyncListener(user_listener); | |||
There was a problem hiding this comment.
Quick question: Is the main reason that we don't std::move the listener pointer on remove because we no longer care about reference counts when it's about to be deleted?
There was a problem hiding this comment.
Moving is only useful when the parameter is accepted by value (or by rvalue reference). This gives the caller's copy away.
In this case, RemoveSnapshotsInSyncListener takes a const reference to the user_listener so moving doesn't do anything, but it's not bumping the reference count anyway.
To answer your follow-up question, RemoveSnapshotsInSyncListener takes the listener by const reference because it's not going to store the listener anyway. It's uses the reference passed to find associated data but forgets about it immediately. You only want to take something like that by value if your method will keep it. In that case std::move in the caller gives the caller's copy away.
wilhuff
force-pushed
the
wilhuff/async-queue-sis
branch
from
52e6801 to
e496a14
Compare
No description provided.