Implement startAfter for RTDB queries
#7209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FirebaseDatabase/Sources/Public/FirebaseDatabase/FIRDatabaseQuery.h
Outdated
Show resolved
Hide resolved
FirebaseDatabase/Sources/Public/FirebaseDatabase/FIRDatabaseQuery.h
Outdated
Show resolved
Hide resolved
FirebaseDatabase/Sources/Public/FirebaseDatabase/FIRDatabaseQuery.h
Outdated
Show resolved
Hide resolved
|
@schmidt-sebastian Ready for another round of review. |
FirebaseDatabase/Sources/Public/FirebaseDatabase/FIRDatabaseReference.h
Outdated
Show resolved
Hide resolved
Comment on lines
80
to
81
| unsigned long i = [next length] - 1; | ||
|
|
There was a problem hiding this comment.
This suggestion removes the empty line between the related statements in line 82 and 84.
|
@schmidt-sebastian Again, thoughts on merge order here? |
schmidt-sebastian
approved these changes
Jan 13, 2021
FirebaseDatabase/CHANGELOG.md
Outdated
| @@ -1,4 +1,5 @@ | |||
| # v7.5.0 | |||
| - [added] Implmemented `queryStartingAfterValue` for FirebaseDatabase queries. | |||
There was a problem hiding this comment.
As mentioned in the other PR, it might be worth mentioning the pagination use case here.
| if ([next characterAtIndex:i] != [MAX_PUSH_CHAR characterAtIndex:0]) { | ||
| break; | ||
| } | ||
| i--; |
There was a problem hiding this comment.
Suggested change
| i--; | |
| --i; |
From the Google style guide: "Use the prefix form (++i) of the increment and decrement operators unless you need postfix semantics."
| withString:MAX_PUSH_CHAR | ||
| startingAtIndex:0]; | ||
| NSString *maxKeySuccessor = [FNextPushId successor:maxKey]; | ||
| XCTAssertEqualObjects(maxKeySuccessor, [FUtilities maxName], @""); |
There was a problem hiding this comment.
You can skip the last argument (or provide a description).
* Implement `endBefore` for RTDB queries * Write tests, various other cleanup * fixup predecessor function * CHANGELOG.md * typo * 2021+ copyrights need LLC * cleanup * style * Update FirebaseDatabase/Sources/Utilities/FNextPushId.m Co-authored-by: Sebastian Schmidt <[email protected]> Co-authored-by: Sebastian Schmidt <[email protected]>
jmwski
changed the title
startAfter for RTDB queriesstartAfter and endBefore for RTDB queries
jmwski
changed the title
startAfter and endBefore for RTDB queriesstartAfter for RTDB queries
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Changes
go/rtdb-exclusive-query-filters