ZipBuilder workaround #7286
Merged
ZipBuilder workaround #7286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanwilson
approved these changes
Jan 12, 2021
Comment on lines
+247
to
+252
| // Be conservative and favor iOS if it exists - and workaround | ||
| // bug where Firebase.h doesn't get installed for tvOS and macOS. | ||
| // Fixed in #7284. | ||
| if podsBuilt[podName] == nil { | ||
| podsBuilt[podName] = podInfo | ||
| } |
There was a problem hiding this comment.
This will only work if iOS is specified first, right?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for crash exposed by different tvOS installation. Fixed in #7284
Keep the workaround longer term to be conservative about preferring the installation form the first platform (iOS) instead of the last (tvOS).
#no-changelog