Skip to content

Automate Release zip build #7560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2021
Merged

Automate Release zip build #7560

merged 2 commits into from
Feb 19, 2021

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Feb 18, 2021 •
edited
Loading

Use Xcode 12.2 to build the zip and built the first real RC via GHA. See https://github.com/firebase/firebase-ios-sdk/actions/runs/579356249.

I noticed that FirebaseAnalytics hasn't been built for Carthage since 7.4.0 and will follow up on that in a subsequent PR.

#no-changelog

@google-cla google-cla bot added the cla: yes label Feb 18, 2021
@google-oss-bot
Copy link

google-oss-bot commented Feb 18, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseDynamicLinks-iOS-FirebaseDynamicLinks.framework

    SDK overall coverage changed from 75.64% (62f7c6c) to 76.69% (9ddd66d) by +1.05%.

    Filename Base (62f7c6c) Head (9ddd66d) Diff
    FDLUtilities.m 90.15% 97.35% +7.20%
    FIRDLDefaultRetrievalProcessV2.m 72.92% 73.96% +1.04%
    FIRDynamicLink.m 80.17% 81.90% +1.72%
    FIRDynamicLinkNetworking.m 80.83% 81.67% +0.83%

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    SDK overall coverage changed from 88.69% (62f7c6c) to 88.66% (9ddd66d) by -0.02%.

    Filename Base (62f7c6c) Head (9ddd66d) Diff
    exception.cc 29.27% 65.85% +36.59%
    leveldb_key.cc 98.08% 96.48% -1.60%
    ordered_code.cc 92.68% 93.24% +0.56%
    serializer.cc 84.40% 83.68% -0.72%
    task.cc 96.41% 95.21% -1.20%
    watch_stream.cc 96.15% 92.31% -3.85%
    write_stream.cc 93.48% 95.65% +2.17%

  • FirebasePerformance-iOS-FirebasePerformance.framework

    SDK overall coverage changed from 87.95% (62f7c6c) to 88.02% (9ddd66d) by +0.07%.

    Filename Base (62f7c6c) Head (9ddd66d) Diff
    FPRGaugeManager.m 94.38% 96.25% +1.88%
    FPRSessionManager.m 84.93% 87.67% +2.74%

Test Logs

maksymmalyhin
maksymmalyhin approved these changes Feb 18, 2021
View reviewed changes
.github/workflows/zip.yml Outdated
- name: Build
run: |
cd ReleaseTooling
swift build -v

package:
# Don't run on private repo.
if: (github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk') || github.event_name == 'workflow_dispatch'
# if: (github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk') || github.event_name == 'workflow_dispatch'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary or just for testing and will be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - just for full testing. I'll remove after green

@paulb777 paulb777 merged commit a422dbf into release-7.7 Feb 19, 2021
@paulb777 paulb777 deleted the pb-automate-zip-build branch February 19, 2021 02:34
@paulb777
Copy link
Member Author

FirebaseAnalytics is not built for Carthage because it provides only an xcframework now and Carthage doesn't yet support binary xcframeworks.

ziadtamim pushed a commit to ziadtamim/firebase-ios-sdk that referenced this pull request Mar 11, 2021
@paulb777 @ziadtamim
Automate Release zip build (firebase#7560)
e98758e
@firebase firebase locked and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @google-oss-bot @maksymmalyhin