Fix recently introduced build warning (#7745) #7755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
maksymmalyhin
approved these changes
Mar 19, 2021
Coverage ReportAffected SDKs
Test Logs
|
maksymmalyhin
added a commit
that referenced
this pull request
Mar 23, 2021
* Update versions for Release 7.9.0 * Fix pod lib lint for watchOS + add CI test (#7740) * Fix pod lib lint for watchOS * Add watchOS build test. * Code review feedback * Typo and formatting * Typo and formatting * fix typo * Add missing test util files to tests targets Co-authored-by: Maksym Malyhin <[email protected]> * Resolve new SPM package install warning (#7741) * Cherry pick: Analytics 7.9.0 RC1 fix (#7750) (#7751) * Analytics 7.9.0 RC1 fix (#7750) * Analytics 7.9.0 RC1 (#7749) Co-authored-by: Allen Vicencio <[email protected]> * Fix recently introduced build warning (#7745) (#7755) * Analytics 7.9.0 RC2 (#7757) (#7759) Co-authored-by: Allen Vicencio <[email protected]> * Revert "Add a warning to upload-symbols when it detects an invalid dSYM (#7705)" (#7761) (#7762) This reverts commit a3eb3b5. * Update SPM analytics for 7.9.0 (#7774) * M92: update FirebaseAnalytics binary link for SPM * SPM: Update GoogleAppMeasurement version Co-authored-by: Ryan Wilson <[email protected]> Co-authored-by: Paul Beusterien <[email protected]> Co-authored-by: Allen Vicencio <[email protected]> Co-authored-by: Sam Edson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't worth a respin on its own, but if there is an RC2, please pull this in as well to fix a Firestore warning regression.