Skip to content

Bump the nanopb version to 0.3.9.8 #7789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 29, 2021
Merged

Bump the nanopb version to 0.3.9.8 #7789

merged 10 commits into from
Mar 29, 2021

Conversation

var-const
Copy link
Contributor

@var-const var-const commented Mar 25, 2021 •
edited by paulb777
Loading

Fixes #7787.

Update to nanopb 0.3.9.8. Protos do not need to be regenerated since this is a library only nanopb patch.

@google-cla google-cla bot added the cla: yes label Mar 25, 2021
@paulb777 paulb777 mentioned this pull request Mar 25, 2021
Merged
@paulb777
Copy link
Member

On quick glance, I see two issues:

@google-oss-bot
Copy link

google-oss-bot commented Mar 26, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    SDK overall coverage changed from 88.53% (7fb172b) to 88.52% (e87a721) by -0.01%.

    Filename Base (7fb172b) Head (e87a721) Diff
    leveldb_key.cc 98.25% 97.81% -0.44%
    ordered_code.cc 92.68% 93.24% +0.56%
    write_stream.cc 95.65% 93.48% -2.17%

  • FirebaseInAppMessaging-iOS-FirebaseInAppMessaging.framework

    SDK overall coverage changed from 43.78% (7fb172b) to 43.99% (e87a721) by +0.21%.

    Filename Base (7fb172b) Head (e87a721) Diff

  • FirebasePerformance-iOS-FirebasePerformance.framework

    SDK overall coverage changed from 88.06% (7fb172b) to 88.04% (e87a721) by -0.03%.

    Filename Base (7fb172b) Head (e87a721) Diff
    FPRNSURLSessionDelegateInstrument.m 98.69% 98.03% -0.66%

Test Logs

paulb777
paulb777 reviewed Mar 26, 2021
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete the extra generated copyrights.

I'm ok if the protos don't get regenerated for 0.3.9.8 since it a library patch only without a corresponding generation change.

The analytics CI failure can be disregarded in this PR since it is a result of the SpecsDev source not being specified at https://github.com/firebase/firebase-ios-sdk/blob/master/.github/workflows/analytics.yml#L25

Crashlytics/Protogen/nanopb/crashlytics.nanopb.c Outdated
@@ -14,6 +14,22 @@
* limitations under the License.
*/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems strange here that the copyright was added but the Generated version string was not updated. Here and in subsequent three files.

@paulb777 paulb777 mentioned this pull request Mar 26, 2021
Merged
@paulb777
Copy link
Member

Merge #7795 to fix the CI failure

@paulb777 paulb777 requested a review from maksymmalyhin March 29, 2021 17:14
@paulb777
Copy link
Member

Asking @maksymmalyhin for a review since both @var-const and I have contributed to this PR

maksymmalyhin
maksymmalyhin approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on CI green

@paulb777
Copy link
Member

Planning to publish the nanopb 2.30908.0 (0.3.9.8) podspec after a day of CI here

@paulb777 paulb777 merged commit 41020e6 into master Mar 29, 2021
@paulb777 paulb777 deleted the varconst/nanopb-0398 branch March 29, 2021 20:23
@firebase firebase locked and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 left review comments

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

Assignees
No one assigned
Labels
api: core api: crashlytics api: firestore api: inappmessaging Firebase In App Messaging cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remediate CVE-2021-21401 by updating to nanopb 0.3.9.8 or higher
4 participants
@var-const @paulb777 @google-oss-bot @maksymmalyhin