Skip to content

Add Index encoders #9247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 25, 2022
Merged

Add Index encoders #9247

merged 8 commits into from
Jan 25, 2022

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Jan 24, 2022

No description provided.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

google-oss-bot commented Jan 24, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 87.65% (b1c5428) to 87.09% (77137a0) by -0.56%.

    FilenameBase (b1c5428)Merge (77137a0)Diff
    exception.cc23.68%73.68%+50.00%
    exception_apple.mm89.66%58.62%-31.03%
    firestore_index_value_writer.cc?0.00%?
    leveldb_key.cc97.68%96.75%-0.93%
    ordered_code.cc94.15%93.41%-0.73%
    value_util.cc97.02%93.58%-3.43%
    write_stream.cc90.14%94.37%+4.23%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mTZCzdDHuw.html

schmidt-sebastian
schmidt-sebastian approved these changes Jan 24, 2022
View reviewed changes
wu-hui
wu-hui commented Jan 25, 2022
View reviewed changes
Copy link
Contributor Author

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wu-hui wu-hui merged commit 52890bf into master Jan 25, 2022
@wu-hui wu-hui deleted the wuandy/IndexEncoder branch January 25, 2022 16:19
leotianlizhan pushed a commit that referenced this pull request Feb 1, 2022
@wu-hui @leotianlizhan
Add Index encoders (#9247)
53e0f6a 
* Index encoders

* Add includes

* Fix lint errors

* Delete TODOs

* Delete a line

* Feedback.

* Grammar

* More comment.
@firebase firebase locked and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@wu-hui wu-hui

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wu-hui @google-oss-bot @schmidt-sebastian