Skip to content

updating change log #9263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2022
Merged

updating change log #9263

merged 2 commits into from
Jan 31, 2022

Conversation

eldhosembabu
Copy link
Contributor

updating change log wrt #9134

@eldhosembabu
updating change log
2496c14 
updating change log wrt #9134
@eldhosembabu eldhosembabu requested a review from paulb777 January 26, 2022 18:28
@eldhosembabu
Copy link
Contributor Author

We could hold this merge until the backend fix for the issue is done. wdyt?

@google-oss-bot google-oss-bot added the api: inappmessaging Firebase In App Messaging label Jan 26, 2022
@google-oss-bot
Copy link

google-oss-bot commented Jan 26, 2022 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseInAppMessaging

    TypeBase (a026e3d)Merge (409b7ec)Diff
    CocoaPods746 kB746 kB-3 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Wx1Q8CmZWw.html

paulb777
paulb777 approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to merge now since the 8.12.0 SDK will support the feature. If we think the back end change will take more than a few weeks, I would suggest adding something like - "This SDK fix will work once the backend is also updated."

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseInAppMessaging-iOS-FirebaseInAppMessaging.framework

    Overall coverage changed from ? (3784deb) to 45.91% (9b9ac32) by ?.

    42 individual files with coverage change

    FilenameBase (3784deb)Merge (9b9ac32)Diff
    FIRIAMActionURLFollower.m?52.22%?
    FIRIAMActivityLogger.m?60.47%?
    FIRIAMAnalyticsEventLoggerImpl.m?57.14%?
    FIRIAMBannerViewController.m?0.00%?
    FIRIAMBannerViewUIWindow.m?0.00%?
    FIRIAMBaseRenderingViewController.m?0.00%?
    FIRIAMBookKeeper.m?87.80%?
    FIRIAMCardViewController.m?0.00%?
    FIRIAMClearcutHttpRequestSender.m?0.00%?
    FIRIAMClearcutLogger.m?61.18%?
    FIRIAMClearcutLogStorage.m?68.57%?
    FIRIAMClearcutUploader.m?90.34%?
    FIRIAMClientInfoFetcher.m?61.98%?
    FIRIAMDefaultDisplayImpl.m?1.78%?
    FIRIAMDisplayCheckOnAnalyticEventsFlow.m?0.00%?
    FIRIAMDisplayCheckOnAppForegroundFlow.m?0.00%?
    FIRIAMDisplayCheckOnFetchDoneNotificationFlow.m?0.00%?
    FIRIAMDisplayCheckTriggerFlow.m?0.00%?
    FIRIAMDisplayExecutor.m?65.55%?
    FIRIAMDisplayTriggerDefinition.m?68.42%?
    FIRIAMElapsedTimeTracker.m?88.46%?
    FIRIAMFetchFlow.m?80.35%?
    FIRIAMFetchOnAppForegroundFlow.m?0.00%?
    FIRIAMFetchResponseParser.m?84.72%?
    FIRIAMImageOnlyViewController.m?0.00%?
    FIRIAMMessageClientCache.m?78.11%?
    FIRIAMMessageContentDataWithImageURL.m?80.39%?
    FIRIAMMessageDefinition.m?100.00%?
    FIRIAMModalViewController.m?0.00%?
    FIRIAMMsgFetcherUsingRestful.m?70.65%?
    FIRIAMRenderingEffectSetting.m?100.00%?
    FIRIAMRenderingWindowHelper.m?0.00%?
    FIRIAMRuntimeManager.m?0.00%?
    FIRIAMSDKModeManager.m?93.22%?
    FIRIAMSDKSettings.m?0.00%?
    FIRIAMServerMsgFetchStorage.m?0.00%?
    FIRIAMTimeFetcher.m?0.00%?
    FIRInAppMessaging+Bootstrap.m?0.00%?
    FIRInAppMessaging.m?3.37%?
    FIRInAppMessagingRenderingDataClasses.m?89.29%?
    NSString+FIRInterlaceStrings.m?100.00%?
    UIColor+FIRIAMHexString.m?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dJc7kqZfRq.html

@eldhosembabu
Copy link
Contributor Author

filed an internal bug to track the backend issue : b/216496087

@eldhosembabu
update
110d40c 
adding additional comments "This SDK fix will work once the backend is also updated."
@eldhosembabu
Copy link
Contributor Author

I think it's fine to merge now since the 8.12.0 SDK will support the feature. If we think the back end change will take more than a few weeks, I would suggest adding something like - "This SDK fix will work once the backend is also updated."

Done. added the above mentioned comment. It seems like backend team needs prioritize this fix and probably would take couple of weeks.

@paulb777 paulb777 added this to the 8.12.0 - M111 milestone Jan 28, 2022
@eldhosembabu eldhosembabu merged commit 114a5b8 into master Jan 31, 2022
@eldhosembabu eldhosembabu deleted the eldhosembabu-patch-1 branch January 31, 2022 18:45
leotianlizhan pushed a commit that referenced this pull request Feb 1, 2022
@eldhosembabu @leotianlizhan
updating change log (#9263)
f97e0d9 
updating change log wrt #9134
@firebase firebase locked and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: inappmessaging Firebase In App Messaging
Projects
None yet
Milestone
8.12.0 - M111
Development

Successfully merging this pull request may close these issues.
3 participants
@eldhosembabu @google-oss-bot @paulb777