Skip to content

Leveldb schema/key change for indexing #9268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 31, 2022
Merged

Leveldb schema/key change for indexing #9268

merged 6 commits into from
Jan 31, 2022

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Jan 27, 2022

No description provided.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

google-oss-bot commented Jan 27, 2022 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (a026e3d)Merge (3097102)Diff
    CocoaPods4.92 MB4.92 MB-3 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Jw2rWEqkYp.html

@google-oss-bot
Copy link

google-oss-bot commented Jan 27, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 87.09% (e486b47) to 87.10% (0bb8f6a) by +0.02%.

    FilenameBase (e486b47)Merge (0bb8f6a)Diff
    exception.cc73.68%23.68%-50.00%
    exception_apple.mm58.62%89.66%+31.03%
    leveldb_key.cc97.37%97.99%+0.62%
    local_serializer.cc93.29%92.23%-1.06%
    task.cc93.04%94.78%+1.74%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MS6azOPt6K.html

@wu-hui wu-hui removed the request for review from schmidt-sebastian January 27, 2022 20:14
schmidt-sebastian
schmidt-sebastian approved these changes Jan 28, 2022
View reviewed changes
schmidt-sebastian
schmidt-sebastian reviewed Jan 31, 2022
View reviewed changes
schmidt-sebastian
schmidt-sebastian reviewed Jan 31, 2022
View reviewed changes
schmidt-sebastian
schmidt-sebastian reviewed Jan 31, 2022
View reviewed changes
schmidt-sebastian added a commit to firebase/firebase-js-sdk that referenced this pull request Jan 31, 2022
@schmidt-sebastian
Add Index Schema
5ca5cbc 
Port of firebase/firebase-ios-sdk#9268
@schmidt-sebastian schmidt-sebastian mentioned this pull request Jan 31, 2022
Merged
@wu-hui wu-hui merged commit 0352c1f into master Jan 31, 2022
@wu-hui wu-hui deleted the wuandy/LevelDbChangeForIndexing branch January 31, 2022 19:43
leotianlizhan pushed a commit that referenced this pull request Feb 1, 2022
@wu-hui @leotianlizhan
Leveldb schema/key change for indexing (#9268)
3a2d208
@firebase firebase locked and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@wu-hui wu-hui

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wu-hui @google-oss-bot @schmidt-sebastian