Run Functions Unit Tests on travis #954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still LGTM. Sorry I made these changes without thinking about how many places we'd have to change to add a new top-level project. We should probably try to find a way to make this more driven by convention than explicitly. |
paulb777
force-pushed
the
pb-travis-functions
branch
2 times, most recently
from
41ce031 to
2bd745b
Compare
paulb777
force-pushed
the
pb-travis-functions
branch
from
2bd745b to
6693482
Compare
|
@wilhuff The needed updates weren't too extensive once I got a decent understanding of how it worked. Agreed that it should have a simpler ramp-up though. I'll plan to revisit in conjunction or soon after the source pod transition unless someone else does it first. Merging now that the tests are running properly and green. |
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.