Skip to content

Update Storage and Functions header comments to Swift markdown #9706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 26, 2022

Conversation

morganchen12
Copy link
Contributor

@morganchen12 morganchen12 commented Apr 25, 2022

See Paul's comments in cl/443496184 for background.

#no-changelog

@morganchen12 morganchen12 changed the title Update Storage header comments to Swift markdown Update Storage and Functions header comments to Swift markdown Apr 25, 2022
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! LGTM. I added some optional suggestions.

@morganchen12 morganchen12 merged commit 96984a0 into master Apr 26, 2022
@morganchen12 morganchen12 deleted the mc/headers branch April 26, 2022 18:04
@firebase firebase locked and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants