Improve macOS/tvOS installation instructions #972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a reasonable band-aid, but I think we could overhaul this to talk more about installation up top, including macOS and tvOS and then separately discuss development and community stuff. Something like
Basically: it doesn't much matter that source pods for non-iOS and Carthage are experimental and/or community supported, we should just put this all in one place so that when people come to figure out how to get it, the answer is one place. |
|
Thanks @wilhuff - I've reorganized as you've suggested and made the source pod instructions more prescriptive. PTAL |
wilhuff
approved these changes
Mar 25, 2018
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
* And provide prescriptive source pod instructions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve docs after feedback at https://twitter.com/mxcl/status/977576224276058112