Skip to content

fix(Analytics) - Add missing dependency on AnalyticsWithoutAdIdSupport for tvOS #9780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2022

Conversation

alexzchut
Copy link
Contributor

@alexzchut alexzchut commented May 8, 2022

Add missing dependency on AnalyticsWithoutAdIdSupport for tvOS

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Fix #9779

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in a feature request so that we
    can discuss it together.

Add missing dependency on AnalyticsWithoutAdIdSupport for tvOS
@google-cla
Copy link

google-cla bot commented May 8, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@alexzchut alexzchut changed the title fix(Analytics) - add analytics dependency without AdId support for tvOS fix(Analytics) - Add missing dependency on AnalyticsWithoutAdIdSupport for tvOS May 8, 2022
@paulb777 paulb777 added this to the 9.1.0 - M116 milestone May 8, 2022
@paulb777
Copy link
Member

paulb777 commented May 8, 2022

@alexzchut Please sign the CLA so we can follow up.

@alexzchut
Copy link
Contributor Author

@paulb777 done

@paulb777 paulb777 merged commit e376c29 into firebase:master May 9, 2022
@alexzchut alexzchut deleted the patch-1 branch May 9, 2022 18:00
@firebase firebase locked and limited conversation to collaborators Jun 9, 2022
@paulb777
Copy link
Member

Hey @alexzchut I'm working on Google Open Source Peer Bonus nominations and would like to recognize your contribution to fixing this Analytics issue. I couldn't find an email address for you, so if you're interested, please email it to paulbeusterien at google.com and I'll make the nomination.

@firebase firebase unlocked this conversation Jul 18, 2022
@alexzchut
Copy link
Contributor Author

alexzchut commented Jul 18, 2022 via email

@firebase firebase locked and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing tvOS Analytics dependency in AnalyticsWithoutAdIdSupport subspec
3 participants